Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fix): update petstore url to fix tests #1877

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

kim-tsao
Copy link
Member

@kim-tsao kim-tsao commented Nov 5, 2024

Description

Please explain the changes you made here.

An e2e test fails when trying to import https://github.com/janus-idp/backstage-showcase/blob/main/catalog-entities/all.yaml with the following error:

{"error":{"name":"InputError","message":"InputError: Processor PlaceholderProcessor threw an error while preprocessing; caused by Error: Placeholder $openapi could not read location https://github.com/OAI/OpenAPI-Specification/blob/main/examples/v3.0/petstore.yaml, NotFoundError: Request failed for https://raw.githubusercontent.com/OAI/OpenAPI-Specification/main/examples/v3.0/petstore.yaml, 404 Not Found"},"request":{"method":"POST","url":"/locations?dryRun=true"},"response":{"statusCode":400}}

The breakage is due to this change which moved the samples to a new location.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@kim-tsao kim-tsao requested a review from a team as a code owner November 5, 2024 00:33
Copy link

sonarcloud bot commented Nov 5, 2024

@kim-tsao
Copy link
Member Author

kim-tsao commented Nov 5, 2024

/cherrypick release-1.3

@openshift-cherrypick-robot

@kim-tsao: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1877!

@kim-tsao
Copy link
Member Author

kim-tsao commented Nov 5, 2024

/cherrypick 1.2.x

@openshift-cherrypick-robot

@kim-tsao: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you.

In response to this:

/cherrypick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Nov 5, 2024

@kim-tsao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests edd5d6d link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nilgaar
Copy link
Contributor

nilgaar commented Nov 5, 2024

/lgtm

Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gustavolira, nilgaar
Once this PR has been reviewed and has the lgtm label, please ask for approval from kim-tsao. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nilgaar nilgaar removed their assignment Nov 5, 2024
@kim-tsao kim-tsao merged commit 6f6e6b6 into janus-idp:main Nov 5, 2024
11 of 13 checks passed
@openshift-cherrypick-robot

@kim-tsao: new pull request created: #1879

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kim-tsao: new pull request created: #1880

In response to this:

/cherrypick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants